-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(protocol): calculate what gasExcess value will push basefee to 1gwei then 10gwei #16550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
test(protocol): calculate in a test what gasExcess will push the basefee to 1gwei
test(protocol): calculate in a test what gasExcess value will push the basefee to 1gwei
Mar 28, 2024
dantaik
changed the title
test(protocol): calculate in a test what gasExcess value will push the basefee to 1gwei
test(protocol): calculate what gasExcess value will push basefee to 1gwei then 10gwei
Mar 28, 2024
test(protocol): calculate what gasExcess value will push basefee to 1gwei then 10gwei
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
davidtaikocha
approved these changes
Mar 28, 2024
Brechtpd
reviewed
Mar 28, 2024
Brechtpd
approved these changes
Mar 28, 2024
davidtaikocha
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the modified test, you'll see if we sell 327 * (gasTarget = 60_000_000) gas, then the basefee will be pushed to 1gwei. This means the current math works.